Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add video hosting platforms category #1974

Merged
merged 8 commits into from
Jul 27, 2020
Merged

Add video hosting platforms category #1974

merged 8 commits into from
Jul 27, 2020

Conversation

jonaharagon
Copy link
Contributor

@jonaharagon jonaharagon commented Jul 3, 2020

Closes #1252, closes #1150 (which I didn't see was a thing before pushing this PR)

This PR lists PeerTube. It does not list Invidious or LBRY (the other two I think probably should be listed, but I haven't seen any discussions opened). Unless we like @lrq3000's writeup at #1252 (comment)? I am also fine adding these platforms to this PR if we are all good here.

@jonaharagon jonaharagon requested a review from a team as a code owner July 3, 2020 03:35
@freddy-m
Copy link
Contributor

freddy-m commented Jul 3, 2020

Perhaps invidio.us could be put under worth mentioning? Mind, you'll also need to update the PrivacyTools services section.

nitrohorse
nitrohorse previously approved these changes Jul 5, 2020
Copy link
Contributor

@nitrohorse nitrohorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@dngray
Copy link
Collaborator

dngray commented Jul 6, 2020

Does anyone else see a missing icon there?

missing_icon

@freddy-m
Copy link
Contributor

freddy-m commented Jul 6, 2020

@dngray yes, I have the same issue.

@jonaharagon
Copy link
Contributor Author

Can't reproduce on two devices?

image

@dngray
Copy link
Collaborator

dngray commented Jul 6, 2020

Can't reproduce on two devices?

I can reproduce it in Firefox, Tor Browser, and on Fennec (Android) as well as Vanadium v83.0.41103.106 (which is Chromium).

@dngray
Copy link
Collaborator

dngray commented Jul 24, 2020

LGTM

@jonaharagon jonaharagon merged commit cdbcd96 into master Jul 27, 2020
@jonaharagon jonaharagon deleted the video-hosting branch July 27, 2020 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Feature Suggestion | Video Streaming
4 participants