Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: functional component #7

Merged
merged 3 commits into from
Mar 26, 2020
Merged

refactor: functional component #7

merged 3 commits into from
Mar 26, 2020

Conversation

privatenumber
Copy link
Owner

@privatenumber privatenumber commented Mar 26, 2020

  • Since PseudoWindow is now a true functional component, it requires a parent component and is technically breaking for new Vue(PseudoWindow). However, this isn't within expected use-case and will not be handled.
  • The refactor allows multiple elements to be returned (feature):
<div>
  <pseudo-window>
    <div>Hello world</div>
    <div>Hello world</div>
    <div>Hello world</div>
  </pseudo-window>
</div>

@privatenumber privatenumber merged commit f4cfc2e into master Mar 26, 2020
@privatenumber privatenumber deleted the functional branch March 26, 2020 01:38
privatenumber added a commit that referenced this pull request Sep 8, 2020
refactor: functional component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant