Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Remove old bootstrap styles #210

Merged
merged 1 commit into from
Mar 28, 2015
Merged

Remove old bootstrap styles #210

merged 1 commit into from
Mar 28, 2015

Conversation

breezewish
Copy link
Member

A little clean up to make page layouts behavior more compatible with latest Bootstrap documentation.

@smcgregor
Copy link
Member

How thoroughly have you tested this? I am prioritizing my PR queue processing and this one will take time to confirm there are no unintended consequences.

@breezewish
Copy link
Member Author

At least login and settings page is OK. I didn't found significant layout issues currently. In fact this commit remove inconformity between the project and bootstrap.

smcgregor added a commit that referenced this pull request Mar 28, 2015
@smcgregor smcgregor merged commit 7f30c20 into privly:master Mar 28, 2015
@smcgregor
Copy link
Member

I think this PR increased the effective line height? There is some extra whitespace at the top of the injected view.

@breezewish
Copy link
Member Author

@smcgregor OK, in injected view, bootstrap.css is not imported, so the margin of <p> becomes bigger.

How about creating a stylesheet specifically for injected view (not for all), includes basic typography styles? Typography styles can be grabbed from bootstrap or any other suitable libraries.

@smcgregor
Copy link
Member

This can be added here: https://github.com/privly/privly-applications/blob/master/shared/css/injected/injected.css

Do you have a suggested stylesheet?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants