This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Add Safari to Unit Tests #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent browsers on SauceLabs using command line argument Change the filesToTest variable based on basePath Changed basePath to current working directory Made similar changes to work on SauceLabs Run SauceLabs tests on specific browsers based on command line argument Default browser for Karma is Firefox. Additional browsers can be set Improved whitespace Use BROWSERS_TO_TEST environment variable only when it is set Used === for string comparison and removed semicolon for var object
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Safari support for TravisCI as well as local tests. A few notes:
export BROWSERS_TO_TEST=Firefox,Chrome,Safarior any browser subset thereof.karma start --browsers Firefox,Chrome,Safari.karma start karma.conf-ci.js --single-run --sauce-browsers=Firefox,Chrome,Safari--browserswill break the SauceLabs script.Special thanks to @sammyshj for figuring out the argument conflicts.
Closes #241