This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Options and History page title bugfix ( #304) #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| {% extends "templates/base.html.template" %} | |||
| {% block head %} | |||
|
|
|||
| {% block title %}<title> New {{ name }}</title>{% endblock %} | |||
| {% block title %}<title> {{ name }}</title>{% endblock %} | |||
There was a problem hiding this comment.
This removes "New" from all apps using new.html.template. A better solution is to implement the title block in the options subtemplate, which will take precedence over the title in this file.
|
Close, would you like tips on Jinja2, or did my inline comments point you in a good direction? |
|
Inline comments did the job. How do I proceed further? Make the necessary changes in the same branch or open a new branch and then do a PR? |
|
Push commits to your same branch. When it is ready for merge I'll ask you to squash your commits so we don't pollute the history. |
|
Documenting new commits:
|
prastut
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added venv/ to gitignore for vitualenv wrapper.