Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xml2js] add support for quadTo and stroke #31

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Oct 9, 2020

In addition

  • log management improvement: when running Svg2Js, underlying Svg2Xml and Xml2Js
    are using the same log levels
  • Xml2Js produce debug logs when processing unsupported elements
  • add tests for Svg2Js
  • avoid logs in Svg2Xml tests

@tbouffard tbouffard added the enhancement New feature or request label Oct 9, 2020
@tbouffard tbouffard changed the title [xml2js] add support for quadTo [xml2js] add support for quadTo and stroke Oct 9, 2020
In addition
- log management improvement: when running Svg2Js, underlying Svg2Xml and Xml2Js
are using the same log levels
- Xml2Js produce debug logs when processing unsupported elements
- add tests for Svg2Js
- avoid logs in Svg2Xml tests
@tbouffard tbouffard force-pushed the feat/xml2js_add_support_for_quadTo branch from 980b9f9 to ee7b5e3 Compare October 16, 2020 10:19
@tbouffard tbouffard marked this pull request as ready for review October 16, 2020 10:20
Copy link

@aibcmars aibcmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbouffard tbouffard merged commit 6a5c79c into develop Oct 16, 2020
@tbouffard tbouffard deleted the feat/xml2js_add_support_for_quadTo branch October 16, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants