Skip to content
This repository has been archived by the owner. It is now read-only.

Electron port #246

Open
wants to merge 70 commits into
base: master
Choose a base branch
from
Open

Electron port #246

wants to merge 70 commits into from

Conversation

davejm
Copy link
Contributor

@davejm davejm commented Jun 17, 2016

From issue #77

Hi,

I set myself the task of making an app in Electron over the Summer and this seemed like a good project to work on with a head start in the logic so I've been working on a port to Electron.

I thought it would be pretty painless but turned out to be quite complicated given the completely different architecture of Electron and the process model.

Anyway I've taken a stab and I think the core functionality is pretty much there. The branch is here: https://github.com/davejm/p5.js-editor/tree/electron-port and there are some notes on the conversion here: https://github.com/davejm/p5.js-editor/blob/electron-port/nw-to-electron-conversion-notes.md.

I based it off an electron vue boilerplate which is linked in the notes. Currently, I'm going to have to take a break from it but it'd be great to finish!

I'm happy to answer any questions and hopefully it can be of some use to the p5js editor project if you want to head in the Electron direction. Let me know if this interests anyone.

This is definitely a work in progress!

Thanks
@antiboredom @lmccart

davejm added 30 commits May 21, 2016 01:51
…x 64bit (I do not have the binary right now). Therefore sound currently doesn't work for linux.
…ad of string (probably a new thing in recent NodeJS versions)
…c e.g. using the remote module for inter-process communication and getting a basic GUI going. Removed linters for the time being
…npoint console errors and see why sketch doesn't work.
…s' when I'd put a load of code in a callback from clearning cache)
…ferencing correctly. Now using electron-window for convenience as well.
…new renderer process in style of nejs inject-js-start; used electron-window's args functionality
…n content loaded. Note that for some reason the vue-devtools only opens if show is true?
davejm added 22 commits June 16, 2016 11:21
…e still issue with minimatch dep. Currently manually patching - looking into using webpack context replace plugin. Implemented serial server
…creations. Also fixed open recent menu item which involved some asynchronous headaches but I'll get to them eventually, I promise
…lement the confirm dialog as atm the download opens regardless if user wants to update or not
…ed my PR to update the serialport dep version
…tuff from the main.html to separate App component as was advised by the boilerplate
… manually patch serialport bindings.js to remove ('bindings')
@bensk
Copy link

bensk commented Jul 18, 2016

Do you have a compiled version we could test? I'm having trouble building my own. Thanks!

@davejm
Copy link
Contributor Author

davejm commented Jul 18, 2016

Hi @bensk I'll try and get a snapshot build up this evening but may not have time! It'll likely be quite unstable but we'll see.

@bensk
Copy link

bensk commented Jul 18, 2016

@davejm thanks so much!

@davejm
Copy link
Contributor Author

davejm commented Jul 18, 2016

@bensk out of interest, is there a particular reason you want to test it? (could try to get something in particular working)

@bensk
Copy link

bensk commented Jul 18, 2016

@davejm I teach p5 during the year, and have been frustrated by the desktop editor. I like having a dedicated editor for my students, and love Atom, so Electron seemed like the next logical step.

@davejm
Copy link
Contributor Author

davejm commented Jul 18, 2016

Ok @bensk. I made a release with compiled binaries. Note there will be bugs. My goal is to at least achieve parity with the nwjs branch. Really there won't be that much difference between the electron and nwjs apps to the user but it's an improvement for development and maintenance I think.
Anyway the release is here: https://github.com/davejm/p5.js-editor/releases/tag/v0.6.0-ELECTRON.1
Please tell me how it goes. Also just close the dev tools that open. That's for testing

@bensk
Copy link

bensk commented Jul 19, 2016

Thanks!

On Mon, Jul 18, 2016 at 5:32 PM, David Moodie [email protected]
wrote:

Ok @bensk https://github.com/bensk. I made a release with compiled
binaries. Note there will be bugs. My goal is to at least achieve parity
with the nwjs branch. Really there won't be that much difference between
the electron and nwjs apps to the user but it's an improvement for
development and maintenance I think.
Anyway the release is here:
https://github.com/davejm/p5.js-editor/releases/tag/v0.6.0-ELECTRON.1
Please tell me how it goes


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#246 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHGwhGtdjhUkI5Eul4A-4x2RPBjoQDHLks5qW_DxgaJpZM4I4jJw
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants