Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Message Archive Management #660

Open
michaeljoelphillips opened this issue Oct 29, 2015 · 31 comments
Open

Feature Request: Message Archive Management #660

michaeljoelphillips opened this issue Oct 29, 2015 · 31 comments
Assignees

Comments

@michaeljoelphillips
Copy link
Contributor

Greetings,

I was wondering if there were any plans to support XEP-0313. I found an issue dated back in 2014 where an issue was tagged as a feature for a Milestone but later removed so I was wondering if Profanity would get support for that in the future. Thanks in advanced!

@boothj5
Copy link
Collaborator

boothj5 commented Oct 29, 2015

Definitely something I'd like to add, just need to find the time.

@mbirth
Copy link

mbirth commented Jan 9, 2017

XEP-0313 is an improvement over XEP-0136 which was requested in #264 .

@qsuscs
Copy link

qsuscs commented Jan 21, 2017

Could this be implemented as a plugin?

@boothj5
Copy link
Collaborator

boothj5 commented Jan 21, 2017

Without having looked too deep into the XEP my guess is the plugins API probably doesn't yet have enough to be able to implement it.

I could be wrong though, some investigation into the XEP and an overview of the flow of stanzas and UI operations would help.

@stevenroose
Copy link

Anything new here? It's been two years almost..

@boothj5
Copy link
Collaborator

boothj5 commented Jul 5, 2017

Not had a look at this feature yet, it's quite a large one and others have taken priority.

I would like to add it in the future though.

@asdil12
Copy link
Contributor

asdil12 commented Jul 5, 2017

Bountysource

@stevenroose
Copy link

@boothj5 ping :)

@evert-mouw
Copy link

Together with Message Carbons, this would make for a perfect console client. Following :)

jubalh added a commit that referenced this issue Nov 1, 2019
XEP-0184: Message Delivery Receipts, *requires* the id attribute.
Generally this is not the case.
For this reason the id was only present in the DeliveryReceipt struct
since it was only used for XEP-0184.

For #660 XEP-0313 MAM
and #805 XEP-0308 Last Message Correction
we will also need the id.

So in preparation for further work let's move the id to the general
ProfBuffEntry.

We will need to adapt code so that we actually always write the ID if we
receive one.
jubalh added a commit that referenced this issue Mar 19, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Mar 24, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Mar 25, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Mar 26, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Mar 27, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Mar 29, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
@jubalh jubalh self-assigned this Mar 30, 2020
jubalh added a commit that referenced this issue Mar 30, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Apr 2, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Apr 2, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Apr 3, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Apr 6, 2020
I plan to save all messages in an SQLite db.
For retrieving information it's nicer than having it in a text file.
We will have more info in there and easier to parse it.

This will also be good for later MAM
(#660).

Regular text files will still be an option for users so that they can
easily grep them and do whatever they like.

Internally Profanity will only use the SQLite db.
jubalh added a commit that referenced this issue Apr 8, 2020
Send a request (which we can't handle yet) :-)

Regards #660
jubalh added a commit that referenced this issue Apr 9, 2020
Send a request (which we can't handle yet) :-)

Regards #660
jubalh added a commit that referenced this issue Apr 11, 2020
Send a request (which we can't handle yet) :-)

Regards #660
@jubalh
Copy link
Member

jubalh commented Apr 13, 2020

#1306 with basic MAM support has been merged.

Only contains basic support.
More work is planned and needed.
Don't enable it yet if you don't know what you are doing. Only for devs.

@jubalh jubalh added this to the 0.13.0 milestone Mar 22, 2022
@jubalh
Copy link
Member

jubalh commented Jun 22, 2022

When implementing MUC MAM we need to tell the MUC that we dont want to get MUC history upon joining anymore.

@jubalh jubalh removed this from the 0.13.0 milestone Sep 7, 2022
@jubalh
Copy link
Member

jubalh commented Oct 21, 2022

#1724 got merged!
MAM in 1:1 support WITH infinite scrollback (reloading from DB) is now done.
Thanks a lot to @MarcoPolo-PasTonMolo for implementing this!

@jubalh
Copy link
Member

jubalh commented Oct 21, 2022

Todo:

  • test (from 21 oct 22 to 11 jan 23 nothing was found)
  • check if autocompletion / quoting works Fix quoting after MAM merge #1770
  • check if plugin api still okay
  • implement MUC MAM

@MarcoPolo-PasTonMolo
Copy link
Collaborator

MarcoPolo-PasTonMolo commented Nov 18, 2022

Also maybe trigger fetching mam when connection gets re-established. Be careful though because if a new message is received before the mam request gets triggered messages that were sent whilst connection was down might get lost

@jubalh
Copy link
Member

jubalh commented Jan 11, 2023

@MarcoPolo-PasTonMolo are you maybe in the mood to take a look at MUC MAM?

@MarcoPolo-PasTonMolo
Copy link
Collaborator

Sadly no. I'm starting to get busy again

MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Jul 1, 2023
TODO split this commit later and see if all its changes are needed

See profanity-im#660
@MarcoPolo-PasTonMolo MarcoPolo-PasTonMolo mentioned this issue Jul 1, 2023
18 tasks
jubalh added a commit that referenced this issue Jul 3, 2023
Started in #1306
for 0.9.0 by me.
We mentioned that it was experimental.

Later heavily improved in
#1724
for upcoming version by MarcoPolo-PasTonMolo.

MUC MAM is in development at:
#1862

Tracking issue: #660
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Jul 8, 2023
Show correct timestamp for mentions and triggers (it used to show
current timestamp instead of the message's one), and flip commands when
displaying history.

See profanity-im#660
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Jul 22, 2023
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Jul 22, 2023
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Jul 22, 2023
MarcoPolo-PasTonMolo added a commit to MarcoPolo-PasTonMolo/profanity that referenced this issue Jul 23, 2023
@emmatebibyte
Copy link

I’m not sure I understand what I’m seeing, but my client reports mam is not enabled on my server when i know it is enabled and working on prosody for other clients. Is this not fully implemented yet?

@jubalh
Copy link
Member

jubalh commented Jul 30, 2024

MAM is implemented for regular chats just not for MUC (group) chats.
The message you are seeing should only appear when the server really doesn't support it.

@emmatebibyte
Copy link

emmatebibyte commented Jul 30, 2024 via email

@jubalh
Copy link
Member

jubalh commented Jul 30, 2024

My other clients claim XEP-0313 is available and function with it. How can I debug this?

Are you running in Proanity in any special way? Like enabling some scripts/plugins or do something before it completely is set up? For example after it connected do you see this message immediately or do you already try to join a couple of MUCs/start chats?

@emmatebibyte
Copy link

emmatebibyte commented Jul 30, 2024 via email

@jubalh
Copy link
Member

jubalh commented Jul 30, 2024

Which server/version? And which Profanity version?

@emmatebibyte
Copy link

emmatebibyte commented Jul 30, 2024 via email

@emmatebibyte
Copy link

Update: MAM works if I wait to open a chat with someone until I’ve closed all open MUC windows.

@emmatebibyte
Copy link

Actually, it seems MAM doesnt work if I receive messages at the start of a session, but if I quit and restart profanity it works.

@barracuda156
Copy link

Hi! Any progress on this? Still no history of messages in the latest release…

@jubalh
Copy link
Member

jubalh commented Dec 9, 2024

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests