Terminate the stream when the server closes the connection #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpadjo
commented
Sep 17, 2022
| @@ -5,3 +5,5 @@ RabbitMQ: | |||
| - "5672:5672" | |||
| environment: | |||
| - DEBUG=false | |||
| volumes: | |||
| - ./rabbit-test-config/:/etc/rabbitmq/ | |||
There was a problem hiding this comment.
Tweak rabbit configuration so it detects missing ack and terminates the channel faster in tests.
With default settings it takes 30 minutes to reproduce the issue
|
@jbwheatley I guess bincompat check failure is related to previous PRs |
|
the mima previous version wasn't pointing to the latest |
|
could you rebase off main? |
|
@jbwheatley done |
jbwheatley
approved these changes
Oct 5, 2022
|
@jbwheatley thank you for merging! Will you have time to run the release sometime in the nearest future? |
|
sorry, looks like releases are blocked by an expired gpg key, and I don't have the relevant permissions on this repo to update it. I've opened an issue and tagged the owners, but in the meantime you may need to publish your own version locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #736