Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple Dispatcher lifetime to stream #528

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Couple Dispatcher lifetime to stream #528

merged 1 commit into from
Apr 1, 2021

Conversation

catostrophe
Copy link
Contributor

Topic should be a resource with the underlying Dispatcher's lifetime coupled to the lifetime of the stream

@bplommer
Copy link
Collaborator

bplommer commented Apr 1, 2021

Looks good, but I don't have a sufficiently robust mental model of stream scopes to be 100% confident that it's correct. It would be good to have a regression test.

@catostrophe
Copy link
Contributor Author

@bplommer
the same pattern is used here:
https://github.com/typelevel/fs2/blob/main/reactive-streams/src/main/scala/fs2/interop/reactivestreams/package.scala#L52

bplommer
bplommer approved these changes Apr 1, 2021
View reviewed changes
Copy link
Collaborator

@bplommer bplommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it's definitely an improvement over what's there now :)

gvolpe
gvolpe approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@gvolpe gvolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gvolpe gvolpe merged commit ffd4561 into profunktor:series/1.x Apr 1, 2021
@catostrophe catostrophe deleted the widen-dispatcher-scope branch April 1, 2021 16:02
@gvolpe gvolpe mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bplommer bplommer bplommer approved these changes

@gvolpe gvolpe gvolpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catostrophe @bplommer @gvolpe