Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translating colours on Matrix #32

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix translating colours on Matrix #32

merged 1 commit into from
Oct 13, 2022

Conversation

jlu5
Copy link
Contributor

@jlu5 jlu5 commented Oct 1, 2022

  • Always translate colour codes IRC -> Matrix with a leading "#"
  • Accept colour codes with and without leading "#" when translating Matrix -> IRC

@jlu5
Fix translating colours on Matrix
4925103 
- Always translate colour codes IRC -> Matrix with a leading "#"
- Accept colour codes with and without leading "#" when translating Matrix -> IRC
@progval
Copy link
Owner

progval commented Oct 1, 2022

I'm going to wait for matrix-org/matrix-spec#1260 to be accepted

@jlu5
Copy link
Contributor Author

jlu5 commented Oct 13, 2022

Ping?

@progval progval merged commit 1c6481d into progval:main Oct 13, 2022
@jlu5 jlu5 deleted the fix-matrix-colour branch December 16, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlu5 @progval