Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoAP discovery handler #346

Closed
wants to merge 17 commits into from
Closed

CoAP discovery handler #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
f3b93f1
Add CoAP discovery handler implementation
jiayihu Jul 1, 2021
21d676b
Integrate CoAP discovery handler to the build system
jiayihu Jul 1, 2021
16dcb72
Add CoAP proposal documentation
jiayihu Jul 1, 2021
231cb60
Minor fixes
jiayihu Jul 1, 2021
b5e58d6
Avoid using custom-configuration and discovery-handler
jiayihu Jul 6, 2021
ddd5a8e
Remove deployment values
jiayihu Jul 13, 2021
4a19654
Fix PR comments
jiayihu Jul 13, 2021
2bc91cf
Fix coap-broker integration
jiayihu Jul 13, 2021
8c9ebd2
Add CoAP discovery handler integration tests
jiayihu Jul 13, 2021
191bbfe
Improve coap-broker error handling
jiayihu Jul 14, 2021
c629440
Add coap-broker to version.sh
jiayihu Jul 14, 2021
365e562
Merge branch 'main' into coap
jiayihu Jul 26, 2021
acd9c51
Add CoAP configuration doc
jiayihu Jul 26, 2021
e87479b
Add CoAP demo
jiayihu Aug 13, 2021
27bc9a4
Merge branch 'main' into coap
jiayihu Aug 13, 2021
647f475
Parallelize discovery for static addresses
jiayihu Aug 13, 2021
6191cdf
Fix typos
jiayihu Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
!target/x86_64-unknown-linux-gnu/debug/webhook-configuration
!target/x86_64-unknown-linux-gnu/release/webhook-configuration
!target/x86_64-unknown-linux-gnu/release/udev-discovery-handler
!target/x86_64-unknown-linux-gnu/release/coap-discovery-handler
!target/x86_64-unknown-linux-gnu/release/coap-broker
!target/x86_64-unknown-linux-gnu/release/debug-echo-discovery-handler
!target/x86_64-unknown-linux-gnu/release/onvif-discovery-handler
!target/x86_64-unknown-linux-gnu/release/opcua-discovery-handler
Expand All @@ -58,6 +60,8 @@
!target/aarch64-unknown-linux-gnu/debug/webhook-configuration
!target/aarch64-unknown-linux-gnu/release/webhook-configuration
!target/aarch64-unknown-linux-gnu/release/udev-discovery-handler
!target/aarch64-unknown-linux-gnu/release/coap-discovery-handler
!target/aarch64-unknown-linux-gnu/release/coap-broker
!target/aarch64-unknown-linux-gnu/release/debug-echo-discovery-handler
!target/aarch64-unknown-linux-gnu/release/onvif-discovery-handler
!target/aarch64-unknown-linux-gnu/release/opcua-discovery-handler
Expand All @@ -72,6 +76,8 @@
!target/armv7-unknown-linux-gnueabihf/debug/webhook-configuration
!target/armv7-unknown-linux-gnueabihf/release/webhook-configuration
!target/armv7-unknown-linux-gnueabihf/release/udev-discovery-handler
!target/armv7-unknown-linux-gnueabihf/release/coap-discovery-handler
!target/armv7-unknown-linux-gnueabihf/release/coap-broker
!target/armv7-unknown-linux-gnueabihf/release/debug-echo-discovery-handler
!target/armv7-unknown-linux-gnueabihf/release/onvif-discovery-handler
!target/armv7-unknown-linux-gnueabihf/release/opcua-discovery-handler
Expand All @@ -80,4 +86,4 @@
!Cross.toml

# Container image license to be copied into every container
!build/container-images-legal-notice.md
!build/container-images-legal-notice.md
2 changes: 2 additions & 0 deletions .github/workflows/build-discovery-handlers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
- arm32v7
- amd64
akri-component:
- coap-discovery
- debug-echo-discovery
- udev-discovery
- onvif-discovery
Expand Down Expand Up @@ -77,6 +78,7 @@ jobs:
strategy:
matrix:
akri-component:
- coap-discovery
- debug-echo-discovery
- udev-discovery
- onvif-discovery
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-test-cases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
BUILD_ARM64: 0
BUILD_SLIM_AGENT: 0
AGENT_FEATURES: "agent-full"
PACKAGES_TO_EXCLUDE: "akri-udev akri-onvif akri-opcua udev-video-broker debug-echo-discovery-handler onvif-discovery-handler opcua-discovery-handler udev-discovery-handler"
PACKAGES_TO_EXCLUDE: "akri-udev akri-onvif akri-opcua udev-video-broker coap-discovery-handler debug-echo-discovery-handler onvif-discovery-handler opcua-discovery-handler udev-discovery-handler"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isnt needed, since it isnt a package in the Agent

PREFIX: ghcr.io/deislabs/akri
LABEL_PREFIX: pr
CARGO_INCREMENTAL: 0
Expand Down
207 changes: 202 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,16 @@ members = [
"shared",
"agent",
"controller",
"samples/apps/coap-device",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this should live in akri as it is a mock device. I feel like the coap-demo.md is sufficient for getting people going. Or we could put it on a branch of akri, or you could host it if interested. @bfjelds for thoughts

"samples/brokers/coap-broker",
"samples/brokers/udev-video-broker",
"webhooks/validating/configuration",
"discovery-utils",
"discovery-handlers/debug-echo",
"discovery-handlers/onvif",
"discovery-handlers/opcua",
"discovery-handlers/udev",
"discovery-handler-modules/coap-discovery-handler",
"discovery-handler-modules/debug-echo-discovery-handler",
"discovery-handler-modules/onvif-discovery-handler",
"discovery-handler-modules/opcua-discovery-handler",
Expand Down
Loading