Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVL changes for SONiC YANG #143

Merged
merged 6 commits into from
Oct 7, 2019
Merged

CVL changes for SONiC YANG #143

merged 6 commits into from
Oct 7, 2019

Conversation

dutta-partha
Copy link
Collaborator

No description provided.

dutta-partha
dutta-partha commented Oct 1, 2019
View reviewed changes
Copy link
Collaborator Author

@dutta-partha dutta-partha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

kwangsuk
kwangsuk reviewed Oct 1, 2019
View reviewed changes
Copy link
Collaborator

@kwangsuk kwangsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Partha. It looks good.
One comment is that we may need to add the "description" substatement where applicable, since these models will be shown as a reference point for writing new SONiC yang.

@dutta-partha
Copy link
Collaborator Author

dutta-partha commented Oct 1, 2019 •
edited
Loading

Yes, we can as needed. We can add them in subsequent changes.

@kwangsuk
Copy link
Collaborator

kwangsuk commented Oct 1, 2019

@dutta-partha Transformer change must be merged together with this PR to avoid disruption. Currently Dell team is using the master branch for Buzznik feature development. Can we hold merging until next Monday?

kwangsuk
kwangsuk approved these changes Oct 7, 2019
View reviewed changes
Copy link
Collaborator

@kwangsuk kwangsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transformer change has been made to support nee change. It will be merged after merging this PR.

@kwangsuk kwangsuk merged commit 88970cb into master Oct 7, 2019
dell-engops pushed a commit that referenced this pull request Sep 27, 2022
@bhavini-gada
Merge pull request #143 from e-sonic/snc-15980_AS_path_list_seqnum
521dc4c 
SNC-15980 Add sequence number ordering for as-path-list
@jeff-yin jeff-yin deleted the cvl_changes_sonic_yang branch September 13, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwangsuk kwangsuk kwangsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutta-partha @kwangsuk