-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformer phase2 #185
Transformer phase2 #185
Conversation
…into cvl_enhancement
Merge transformer phase 2 to arlo master
Syncing project-arlo/sonic-mgmt-framework master to brcm_poc
merge transformer phase-2 to master : Clean up of files and add missed items during previous merge
CVL enhancements
Exclude annotation file from generating ocbinds, fix Makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(1) Just general nitpicking about tabs
(2) Question about whether we should be including skeleton code and "in-progress" code in general.
@@ -3,6 +3,10 @@ module sonic-common { | |||
namespace "http://github.com/Azure/sonic-common"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix the indentation in this file to be 4-space tabs?
@@ -0,0 +1,80 @@ | |||
<?xml version='1.0' encoding='UTF-8'?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a CLI skeleton at this point, with no back-end support. Is this going to be OK to merge to the SONiC community?
@@ -0,0 +1,327 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a CLI skeleton at this point, with no back-end support. Is this going to be OK to merge to the SONiC community?
} | ||
|
||
func getRequestBinder(uri *string, payload *[]byte, opcode int, appRootNodeType *reflect.Type) *requestBinder { | ||
return &requestBinder{uri, payload, opcode, appRootNodeType, nil} | ||
return &requestBinder{uri, payload, opcode, appRootNodeType, nil, nil, false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to fix indentation in this file (and throughout this PR) to 4-space tabs
…are-to-dell_sonic_4.x_share sync from broadcom_sonic_4.x_share to dell_sonic_4.x_share - 0919
No description provided.