Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer phase2 #185

Closed
wants to merge 31 commits into from
Closed

Transformer phase2 #185

wants to merge 31 commits into from

Conversation

PrabhuSreenivasan
Copy link
Collaborator

No description provided.

asha-behera and others added 26 commits September 20, 2019 15:03
Merge transformer phase 2 to arlo master
Syncing project-arlo/sonic-mgmt-framework master to brcm_poc
merge transformer phase-2 to master : Clean up of files and add missed items during previous merge
Exclude annotation file from generating ocbinds, fix Makefile
Copy link
Collaborator

@jeff-yin jeff-yin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(1) Just general nitpicking about tabs
(2) Question about whether we should be including skeleton code and "in-progress" code in general.

@@ -3,6 +3,10 @@ module sonic-common {
namespace "http://github.com/Azure/sonic-common";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the indentation in this file to be 4-space tabs?

@@ -0,0 +1,80 @@
<?xml version='1.0' encoding='UTF-8'?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a CLI skeleton at this point, with no back-end support. Is this going to be OK to merge to the SONiC community?

@@ -0,0 +1,327 @@
<?xml version="1.0"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a CLI skeleton at this point, with no back-end support. Is this going to be OK to merge to the SONiC community?

}

func getRequestBinder(uri *string, payload *[]byte, opcode int, appRootNodeType *reflect.Type) *requestBinder {
return &requestBinder{uri, payload, opcode, appRootNodeType, nil}
return &requestBinder{uri, payload, opcode, appRootNodeType, nil, nil, false}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to fix indentation in this file (and throughout this PR) to 4-space tabs

dell-engops pushed a commit that referenced this pull request Sep 27, 2022
…are-to-dell_sonic_4.x_share

sync from broadcom_sonic_4.x_share to dell_sonic_4.x_share - 0919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.