matter-devices.xml: Fix DEM (Simple -> Utility) #36458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the DEM device type description in matter-devices.xml. The most relevant change is fixing the class type from Simple to Utility. This was generated using alchemy with the command: ``` alchemy/alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip-spec/ ./connectedhomeip-spec/src/device_types/DeviceEnergyManagement.adoc ```
|
Review changes with |
|
PR #36458: Size comparison from 882b76e to aa18dae Full report (7 builds for cc32xx, qpg, stm32, tizen)
|
|
PR #36458: Size comparison from 882b76e to 215de8a Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
examples/dishwasher-app/silabs/data_model/dishwasher-wifi-app.matter
Outdated
Show resolved
Hide resolved
|
@soares-sergio Maybe you sould also fix it in zap-templates: <deviceType>
<name>Device Energy Management</name>
<domain>CHIP</domain>
<typeName>Device Energy Management</typeName>
<class>Simple</class>
<profileId editable="false">0x0103</profileId>
<deviceId editable="false">0x050D</deviceId>
<clusters lockOthers="true">
<include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true"></include>
<include cluster="Device Energy Management" client="false" server="true" clientLocked="true" serverLocked="true"></include>
<include cluster="Device Energy Management Mode" client="false" server="true" clientLocked="true" serverLocked="false"></include>
</clusters>
</deviceType> |
I believe that's what I did @lboue . As far as I know there's only one |
|
PR #36458: Size comparison from 882b76e to 415f6e7 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Nov 11, 2024
tehampson
approved these changes
Nov 12, 2024
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* matter-devices.xml: Fix DEM (Simple -> Utility) This change fixes the DEM device type description in matter-devices.xml. The most relevant change is fixing the class type from Simple to Utility. This was generated using alchemy with the command: ``` alchemy/alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip-spec/ ./connectedhomeip-spec/src/device_types/DeviceEnergyManagement.adoc ``` * zap regen * Fix name to avoid unwanted changes on Zap generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the DEM device type description in matter-devices.xml. The most relevant change is fixing the class type from Simple to Utility.
This was generated using alchemy with the command:
Slack discussion for additional context: https://csamembers.slack.com/archives/C01B01GH64E/p1731007309335719