-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClientNode implementation round 3 #1711
Open
lauckhart
wants to merge
1
commit into
project-chip:main
Choose a base branch
from
lauckhart:client-node3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protocol-level plumbing factors out various bits of controller- and client-related logic into more composable APIs: - Decouples PeerSet from InteractionClient and adds a (mostly stubbed) client Interactable - Modifies client networking to expose incoming data reports as a stream - Exposes physical device properties and subscription client as independent APIs - Extracts interface and logic to support working with partially-decoded data reports on the client - Adds hooks to InteractionServer to support delegation of subscription responses to a client implementation Also fleshes out operational networking for client nodes. Operational discovery is in place but actual interaction is blocked pending implementation of client Interactable implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol-level plumbing factors out various bits of controller- and client-related logic into more composable APIs:
Also fleshes out operational networking for client nodes. Operational discovery is in place but actual interaction is blocked pending client Interactable implementation.