Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust env tests for RayCluster controller #505

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Apr 8, 2024

Issue link

N/A
It initially started as a simple test adjustment. It ends up....

What changes have been made

Created GH workflow executing the component tests.
Rewrote the tests to use go lang k8s client. Fix various issues and errors in tests.
Adjusted getClusterType to remove unnecessary code.

Verification steps

Tests can be executed using make test-component.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal, astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9f5bde6 into project-codeflare:main Apr 18, 2024
8 checks passed
@sutaakar sutaakar deleted the fix-tests branch April 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants