Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AppWrapper from v1.0.0 to v1.0.4 #662

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

dgrove-oss
Copy link
Collaborator

Features

  • Propagate SchedulingGates in RunWithPodSetsInfo
  • extend PodSets() to compute TopologyRequest
  • Support PreferNoSchedule labels for AutoPilot
  • Implement PodSet inference for JobSet

Bugs and Regressions

  • move appwrapper finalizer injection from defaulting webhook to controller
  • use ptr.Equal to validate managedBy is immutable
  • fix handling of labels/annotations in utils.GetPodTemplateSpec

Features
  + Propagate SchedulingGates in RunWithPodSetsInfo
  + extend PodSets() to compute TopologyRequest
  + Support PreferNoSchedule labels for AutoPilot
  + Implement PodSet inference for JobSet

Bugs and Regressions
  + move appwrapper finalizer injection from defaulting webhook to controller
  + use ptr.Equal to validate managedBy is immutable
  + fix handling of labels/annotations in utils.GetPodTemplateSpec
@sutaakar
Copy link
Contributor

/lgtm

Copy link
Contributor

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e99e560 into project-codeflare:main Feb 13, 2025
8 checks passed
@dgrove-oss dgrove-oss deleted the aw-bump branch February 13, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants