Update readme and the Makefile to remove outdated instructions and adjust the local test timeouts #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bobbins228
requested changes
Feb 27, 2025
| @@ -24,6 +24,7 @@ Requirements: | |||
| # brew install gnu-sed | |||
| make install -e SED=/usr/local/bin/gsed | |||
| ``` | |||
| - Kind - kind is used in the kind-e2e command in the make file. Follow these instructions for the kind setup <a href="https://kind.sigs.k8s.io/docs/user/quick-start/" targe="_blank">here</a> | |||
There was a problem hiding this comment.
Suggested change
| - Kind - kind is used in the kind-e2e command in the make file. Follow these instructions for the kind setup <a href="https://kind.sigs.k8s.io/docs/user/quick-start/" targe="_blank">here</a> | |
| - Kind - Kind is used in the kind-e2e command in the Makefile. Follow these instructions for the kind setup <a href="https://kind.sigs.k8s.io/docs/user/quick-start/" target="_blank">here</a> |
| [!NOTE] | ||
| If you get an error on linux | ||
| ``` | ||
| Error: rootlessport cannot expose privileged port 80 |
There was a problem hiding this comment.
Is this a common issue?
|
@2000krysztof You are failing on the pre-commit I would recommend installing it and running |
added 8 commits
March 7, 2025 14:43
…st command skip GPU tests
…30m and the medium to 5m
…t varaibles to the Makefile in the test-e2e special target
2000krysztof
force-pushed
the
readmeUpdate
branch
from
a89287f to
a0cb56e
Compare
ChristianZaccaria
changed the title
Run pre-commits
2000krysztof
force-pushed
the
readmeUpdate
branch
from
a0cb56e to
c97e217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Jira : https://issues.redhat.com/browse/RHOAIENG-19986
What changes have been made
Verification steps
Please go through the instructions in the readme.
Checks