[server][Action] Reexecute action mechanism. #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a feature that executes unfinished actions when Hatohol server restarts. Currently, when the Hatohol server craashes or quits forcely, running and queued actions aren't taken care on the restart of Hatohol server.
kz0817
commented
Dec 22, 2016
| eventOption.setTargetServerId(actionLog.serverId); | ||
| eventOption.setEventIds({actionLog.eventId}); | ||
| dbMonitoring.getEventInfoList(eventList, eventOption); | ||
| if (eventList.empty()) |
There was a problem hiding this comment.
Do we have to show warning in this condition ?
There was a problem hiding this comment.
I think it is better to show logs
kz0817
commented
Dec 22, 2016
| actionOption.setActionIdList(actionIdList); | ||
| dbAction.getActionList(actionList, actionOption); | ||
|
|
||
| if (actionList.empty()) |
cosmo0920
reviewed
Dec 22, 2016
|
|
||
| // Re execute unfinished action | ||
| ActionManager actionManager; | ||
| actionManager.reExecuteUnfinishedAction(); |
There was a problem hiding this comment.
memo: I've noticed that Hatohol server blocks in this line when bunch of unfinished actions are remained.
But for now, this implementation is no problem to re-execute unfinished actions.
This patch logs an error messages when the event or action is not found and should be merged into the following commit. commit 512ecdc Author: Kazuhiro Yamato <[email protected]> Date: Wed Dec 21 19:39:44 2016 +0900 [server][Action] Reexecute action mechanism.
|
I added an error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revised version of #2471
This patch adds a feature that executes unfinished actions
when Hatohol server restarts.
Currently, when the Hatohol server craashes or quits forcely,
running and queued actions aren't taken care on the restart of
Hatohol server.