Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5368] prep for AWS Glue Data Catalogue migration #5449

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Jan 16, 2025

Jira Ticket

COST-5368

Description

This change will do a few things:

  1. rename the sql_params schema_name to schema (for the sake of consistency)
  2. add trino_schema_prefix to all sql files and sql_params where necessary
  3. add TRINO_SCHEMA_PREFIX env variable -> defaults to empty initially
  4. add TRINO_S3A_OR_S3 env variable -> defaults to s3a initially (what it currently is today)
  5. add SCHEMA_SUFFIX env variable -> currently unused, but will be used after we switch to Glue for local and ephemeral
  6. add more separation between HCS, ROS, SUBS S3 params in settings. Move HCS S3 upload to the CSVhandler.

Testing

  1. smokes

Release Notes

  • proposed release note
* [COST-5368](https://issues.redhat.com/browse/COST-5368) prep for AWS Glue Data Catalogue migration

@maskarb maskarb added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 16, 2025
@maskarb maskarb requested review from a team as code owners January 16, 2025 00:39
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.1%. Comparing base (aabdbae) to head (b9c4154).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5449     +/-   ##
=======================================
- Coverage   94.2%   94.1%   -0.0%     
=======================================
  Files        370     370             
  Lines      31539   31550     +11     
  Branches    3378    3381      +3     
=======================================
+ Hits       29700   29702      +2     
- Misses      1196    1200      +4     
- Partials     643     648      +5     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant