Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TotalSeg configs and supporting code #8

Merged
merged 19 commits into from
Aug 2, 2024
Merged

TotalSeg configs and supporting code #8

merged 19 commits into from
Aug 2, 2024

Conversation

surajpaib
Copy link
Collaborator

No description provided.

@surajpaib surajpaib requested a review from ibro45 July 18, 2024 20:52
init_LR: 0.001
project: "ct_fm_quick_class_eval"
in_channels: 1
embedding_dim: 512
format: "$'suprem' if 'suprem' in @CONSTANTS#name else 'lighter'"
format: "$'suprem' if 'suprem' in @vars#name else 'lighter'"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially problematic for new models

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this won't be missed as newer models we'll have to figure out input configurations again and edit this as well. I'll move it over to a dict or so then

@ibro45
Copy link
Collaborator

ibro45 commented Jul 26, 2024

let me know when i can merge this, will add head abnormality classification then following the same structure

@surajpaib
Copy link
Collaborator Author

@ibro45 You can merge it already if you like.

But I will add a script file for TS with specifics on how to run it.

Some changes I made,

name and project will be passed through scripts CLI overrides instead of in the config. There are way too many options now adding to confusion potentially.

@surajpaib surajpaib changed the title Technical ablations TotalSeg configs and supporting code Aug 1, 2024
@surajpaib
Copy link
Collaborator Author

@ibro45

I've tested all the configs once and looked added several improvements to the pipeline for TS

  1. Val is on 256 cubic, this covers a lot more across the z-axis, see image
image
  1. Metrics are generalized dice from MONAI fork (Fix generalized dice computation Project-MONAI/MONAI#7970). The main reason for adding this is that if pred is zero and gt is zero, the dice is set to 1. Torchmetrics sets this to zero and is difficult to override. Metrics are averaged across all labels and metrics are logged also per label with their semantic naming.

  2. Added wandb image logger as seen in the image, its a simple callback on the first image/batch in the validation. This is mostly for sanity checks.

  3. Data loading modified for TS so that different splits and label groups can be loaded based on dataframe filtering.

  4. Predict workflow added (it runs but need to test for accuracy of results)

@surajpaib
Copy link
Collaborator Author

Going to run the comparison against Merlin now (end-to-end) to see if the workflow is good. I'll also move on to MSD and hope to finish that asap

@surajpaib
Copy link
Collaborator Author

@ibro45 Time to merge?

@surajpaib
Copy link
Collaborator Author

#10

@ibro45 ibro45 merged commit 6df3746 into main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants