Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Feature: add arduino master to launch #527

Merged
merged 3 commits into from
May 29, 2020
Merged

Feature: add arduino master to launch #527

merged 3 commits into from
May 29, 2020

Conversation

Olavhaasie
Copy link
Contributor

Description

I noticed that I forgot to add the serial connection with the embedded Arduino on the master to the launch files. I have added the node to serial_connection.launch, which seemed like a suitable location for it.

Changes

  • Add arduino_master node launching
  • Add arduino_master option to march_launch and march_headless.launch

@Olavhaasie Olavhaasie requested a review from a team as a code owner May 27, 2020 12:59
@Olavhaasie Olavhaasie self-assigned this May 27, 2020
@JorisWeeda JorisWeeda merged commit 0344729 into develop May 29, 2020
@JorisWeeda JorisWeeda deleted the feature/add-arduino-master-to-launch branch May 29, 2020 10:32
@Olavhaasie Olavhaasie mentioned this pull request Jun 1, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JorisWeeda JorisWeeda JorisWeeda approved these changes

@Roelemans Roelemans Roelemans approved these changes

Assignees

@Olavhaasie Olavhaasie

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Olavhaasie @JorisWeeda @Roelemans