Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Feature: multiplot configs #31

Merged
merged 13 commits into from
Mar 24, 2020
Merged

Conversation

RutgerVanBeek
Copy link
Contributor

@RutgerVanBeek RutgerVanBeek commented Mar 23, 2020

Closes PM-335

Description

This reintroduces the central folder for rqt_multiplot configurations. Making this available for everyone should help in getting the necessary plots fast.

Some general comments:

  • I have set all the axis labels with units (if applicable), but turned them off, to make the plot bigger. They can easily be shown by opening the plot configuration (you only have to select the checkbox as the name is already correct).
  • I have decided to make configuration rather have to little than too many plots as it is easier to remove then to add things.
  • In general I have used the time stamp from the message as the the time, because this is more reliable and in some cases there is no clock running (when playing a bag file). Exception to this is the update of PID parameters as these messages do not contain a header.
  • All time-axis are set to show the last 10 seconds.
  • All y-axis are set to automatic scaling. Exception is the temperature as we don't want temperatures above 100 to fuck up our graph.

Available plots:

  • actual_desired: This plots the actual and desired position for each joint separately.
  • controller_output: This plots the controller output for each joint. Next to that it plots the after limit joint command to see the effect of the safety controller.
  • joint_values: Plots the actual position, velocity, acceleration and jerk for each joint.
  • pid_terms: Plots the amount the P, I and D are contributing to the effort command for each joint.
  • pid_updates: Plots the P, I and D values us updated by gain scheduling. This is the only plot that is not a line plot as the frequency of updating can also be of interest.
  • temperature: Plots the temperature for each joint.
  • controller_per_joint folder: This is a folder with a configuration for each joint. The configuration contains the actual/desired position, the error in position, after limit joint command, actual effort, error dot and actual/desired velocity, but just for one joint.

Changes

  • Added a folder with a lot of rqt_multiplot configurations.

@RutgerVanBeek RutgerVanBeek requested a review from a team as a code owner March 23, 2020 15:12
@RutgerVanBeek RutgerVanBeek requested review from Olavhaasie and JorisWeeda and removed request for a team March 23, 2020 15:12
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #31 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #31   +/-   ##
========================================
  Coverage    75.34%   75.34%           
========================================
  Files            9        9           
  Lines          361      361           
  Branches        40       40           
========================================
  Hits           272      272           
  Misses          82       82           
  Partials         7        7           
Flag Coverage Δ
#production 54.14% <ø> (ø)
#test 96.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f8ff7...0250f06. Read the comment docs.

@Olavhaasie Olavhaasie requested a review from Roelemans March 23, 2020 15:16
@Olavhaasie Olavhaasie changed the title Feature/pm 335 multiplot configs Feature: multiplot configs Mar 23, 2020
Olavhaasie
Olavhaasie previously approved these changes Mar 23, 2020
Copy link
Contributor

@Olavhaasie Olavhaasie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, I have tested a few, so let's hope they all work 🤞

Copy link
Contributor

@Roelemans Roelemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice! Your really put in some effort :O
A few comments on axis:
For the temprature plot, the axis are automatic instead of relative. Is this on purpose? Maybe nice indeed to see temprature over entire time
PID_update plot has absolute y-axis. Perhaps relative is better here?
Controller_output plots points instead of lines.

@RutgerVanBeek RutgerVanBeek requested a review from Roelemans March 24, 2020 08:44
@Roelemans Roelemans merged commit 01cdd31 into develop Mar 24, 2020
@Roelemans Roelemans deleted the feature/PM-335-multiplot-configs branch March 24, 2020 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants