Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Feature/pm 391 sm to unknown button #34

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

JorisWeeda
Copy link
Contributor

Closes PM-391
(Also use the feature/PM-391-set-state-machine-to-unknown in the march repo)

Description

Added a button with a callback that sends the UNKNOWN tag as GaitInstruction.msg

Changes

  • new button to set the state machine to unknown
  • callback of the button

… machine back to state UNKNOWN. Also added a button which has a callback to publish this tag.
@JorisWeeda JorisWeeda requested a review from a team as a code owner April 7, 2020 12:57
@JorisWeeda JorisWeeda requested review from Olavhaasie and RutgerVanBeek and removed request for a team April 7, 2020 12:57
@JorisWeeda JorisWeeda changed the title Added an unknown tag to the gait instruction message to set the state… feature/PM-391-sm-to-unknown-button Apr 7, 2020
@JorisWeeda JorisWeeda changed the title feature/PM-391-sm-to-unknown-button Feature/PM-391-sm-to-unknown-button Apr 7, 2020
@JorisWeeda JorisWeeda changed the title Feature/PM-391-sm-to-unknown-button Feature/pm 391 sm to unknown button Apr 7, 2020
Copy link
Contributor

@RutgerVanBeek RutgerVanBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for merging until the one in the March repo is merged.

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #34 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #34   +/-   ##
========================================
  Coverage    75.34%   75.34%           
========================================
  Files            9        9           
  Lines          361      361           
  Branches        40       40           
========================================
  Hits           272      272           
  Misses          82       82           
  Partials         7        7           
Flag Coverage Δ
#production 54.14% <ø> (ø)
#test 96.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e17c081...3503b07. Read the comment docs.

@JorisWeeda JorisWeeda merged commit b1b168c into develop Apr 10, 2020
@JorisWeeda JorisWeeda deleted the feature/PM-391-sm-to-unknown-button branch April 10, 2020 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants