Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments to generate_grpc_code are inconsistent with tonic and prost #4587

Closed
tiziano88 opened this issue Jan 3, 2024 · 0 comments · Fixed by #4591
Closed

Arguments to generate_grpc_code are inconsistent with tonic and prost #4587

tiziano88 opened this issue Jan 3, 2024 · 0 comments · Fixed by #4591
Assignees

Comments

@tiziano88
Copy link
Collaborator

pub fn generate_grpc_code(
proto_path: &str,
file_paths: &[&str],
options: CodegenOptions,
) -> std::io::Result<()> {

https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.compile_protos:

pub fn compile_protos(
    &mut self,
    protos: &[impl AsRef<Path>],
    includes: &[impl AsRef<Path>]
) -> Result<()>

https://docs.rs/tonic-build/0.10.2/tonic_build/struct.Builder.html#method.compile:

pub fn compile(
    self,
    protos: &[impl AsRef<Path>],
    includes: &[impl AsRef<Path>]
) -> Result<()>
@tiziano88 tiziano88 self-assigned this Jan 3, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 3, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 3, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 3, 2024
Use same name, type and semantics as prost and tonic.

Simplify the change tracking logic.

Fix project-oak#4587
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 4, 2024
Use same name, type and semantics as prost and tonic.

Simplify the change tracking logic.

Fix project-oak#4587
tiziano88 added a commit that referenced this issue Jan 5, 2024
Use same name, type and semantics as prost and tonic.

Simplify the change tracking logic.

Fix #4587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant