Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use WORKSPACE_ROOT to resolve protos. #4597

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Don't use WORKSPACE_ROOT to resolve protos. #4597

merged 1 commit into from
Jan 4, 2024

Conversation

jblebrun
Copy link
Contributor

@jblebrun jblebrun commented Jan 3, 2024

No description provided.

@jblebrun jblebrun marked this pull request as ready for review January 3, 2024 21:51
tiziano88
tiziano88 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@tiziano88 tiziano88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jblebrun jblebrun force-pushed the no-workspace-root-proto-build branch 2 times, most recently from 3fc3495 to 0bb3402 Compare January 4, 2024 18:53
@jblebrun jblebrun force-pushed the no-workspace-root-proto-build branch from 0bb3402 to 12a4fd1 Compare January 4, 2024 20:27
@tiziano88
Copy link
Collaborator

@ernoc FYI I think this is also related to your change of centralizing rust protos #4583

@jblebrun jblebrun merged commit c68edf6 into project-oak:main Jan 4, 2024
17 checks passed
@jblebrun jblebrun deleted the no-workspace-root-proto-build branch January 4, 2024 22:01
@tiziano88 tiziano88 mentioned this pull request Jan 5, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiziano88 tiziano88 tiziano88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jblebrun @tiziano88