Use zeroize to clear DICE secrets #4645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipetr0v
approved these changes
Jan 12, 2024
| @@ -215,7 +202,7 @@ impl ApplicationKeys { | |||
| static_assertions::assert_eq_size!([u8; 2048], ApplicationKeys); | |||
|
|
|||
| /// ECDSA private keys that can be used for an application for signing or encryption. | |||
| #[derive(AsBytes, FromZeroes, FromBytes)] | |||
| #[derive(AsBytes, FromZeroes, FromBytes, Zeroize, ZeroizeOnDrop)] | |||
There was a problem hiding this comment.
Wow, it has zeroize on drop already, nice
Will use it for the private key in the crypto as well
conradgrobler
force-pushed
the
zeroize
branch
from
8ddf562 to
a98fe26
Compare
|
Ref #4513 |
conradgrobler
force-pushed
the
zeroize
branch
from
a98fe26 to
b7408a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
.fill(0)to clear DICE-related secrets, but this could be optimised away by the compiler. The zeroize crate provides a more tobust mechanism for clearing secrets from memory, so switching to that.