Rename RecipientContextGenerator into EncryptionKeyHandle in C++ #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiziano88
approved these changes
Jan 18, 2024
| auto encryption_key_provider = EncryptionKeyProvider::Create(); | ||
| if (!encryption_key_provider.ok()) { | ||
| return encryption_key_provider.status(); | ||
| auto encryption_key = EncryptionKeyProvider::Create(); |
There was a problem hiding this comment.
Not sure I understand the rename: creating an EncryptionKeyProvider now returns an encryption key?
There was a problem hiding this comment.
I'm currently trying to distinguish between key handles and actual keys.
And the "provider" name will be dropped in a following PR
ipetr0v
force-pushed
the
cpp_encryption_key_handle
branch
from
bc552ff to
24d33f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4490