Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a WASI placeholder #529

Merged
merged 8 commits into from
Jan 30, 2020
Merged

Add a WASI placeholder #529

merged 8 commits into from
Jan 30, 2020

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Jan 27, 2020 •
edited
Loading

This change:

  • Adds a WASI placeholder in order to run TensorFlow Lite example in Oak
  • Update TensorFlow Lite example main functions

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@ipetr0v ipetr0v marked this pull request as ready for review January 27, 2020 17:25
@ipetr0v ipetr0v requested a review from tiziano88 January 27, 2020 17:25
tiziano88
tiziano88 reviewed Jan 27, 2020
View reviewed changes
oak/server/wasm_node.cc Outdated Show resolved Hide resolved
examples/tensorflow/client/tensorflow.cc Show resolved Hide resolved
@ipetr0v ipetr0v requested a review from tiziano88 January 28, 2020 14:15
tiziano88
tiziano88 approved these changes Jan 29, 2020
View reviewed changes
oak/server/wasm_node.cc Show resolved Hide resolved
oak/server/wasm_node.cc Outdated Show resolved Hide resolved
oak/server/wasm_node.cc Show resolved Hide resolved
@ipetr0v ipetr0v merged commit e6e6b55 into project-oak:master Jan 30, 2020
@ipetr0v ipetr0v deleted the wasi_placeholder branch January 30, 2020 12:15
@daviddrysdale daviddrysdale mentioned this pull request Apr 6, 2020
Closed
@ipetr0v ipetr0v mentioned this pull request Apr 7, 2020
Closed
15 tasks
daviddrysdale added a commit that referenced this pull request Apr 15, 2020
@daviddrysdale
runtime/rust: add WASI placeholders
7b73b84 
Equivalent to the C++ placeholders in oak/server/wasm_node.cc
added in #529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiziano88 tiziano88 tiziano88 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipetr0v @tiziano88 @googlebot