-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub actions to build and publish Rust docs #866
Conversation
9f82564
to
b0edb4d
Compare
7122359
to
3c03851
Compare
f83c122
to
f5e2085
Compare
This is not feasible on GCP because we don't have a way of authenticating only post-merge workflows. GitHub actions instead get provisioned with a read-only token for pull requests, and with a read + write token for merge.
f5e2085
to
854ec1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This seems to be generating ~/src/oak{master}:git log -n3 --oneline upstream/gh-pages
4d09e945bc42 (upstream/gh-pages) Update gh-pages from bc98624bdcf6629c4f3ef4aa139bd4a0892f3744
cf1d4380558d Update gh-pages from 6ceb81cabc00decf21e2875bbeac9d7fabd8b1fe
4e733345b21e Update gh-pages from 9ccaae8f7b94006b8f23f5c9d9ca8f88b3fe66f5
~/src/oak{master}:git diff --name-only 9ccaae8f7b94006b8f23f5c9d9ca8f88b3fe66f5..6ceb81cabc00decf21e2875bbeac9d7fabd8b1fe
Dockerfile
docs/INSTALL-OSX.md
scripts/build_server
scripts/run_server |
Yes it will generate them for each commit, I imagine we could write some regexp to only trigger the workflow if any Rust file (or proto file, or BUILD file, etc...) changed, but I don't think it's worth the effort, the point of this is that it is now automated and we don't need to deal with it. |
Ah but I see your point, now we have random commits like this: cf1d438 which AFAICT are just caused by some non-determinism in the generation. |
Yeah, I didn't think Having a commit on
Something along these lines was deleted in d7d8dbd |
This is not feasible on GCP because we don't have a way of
authenticating only post-merge workflows.
GitHub actions instead get provisioned with a read-only token for pull
requests, and with a read + write token for merge.