Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run both C++ and Rust Loader #958

Closed
wants to merge 1 commit into from

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented May 6, 2020

This change updates macro and scripts in order to be able to run C++ and Rust Oak Loaders on the same examples.

Fixes #874

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have checked that these tests are run by Cloudbuild

@ipetr0v ipetr0v added the WIP Work in progress label May 6, 2020
@tiziano88
Copy link
Collaborator

FYI, as discussed in the on-demand, I think we should go ahead and switch directly from running the examples from C++ to Rust, without trying to artificially support both. I think when gRPC client and server nodes are supported, we can have a PR that switches running the examples with the Rust runtime, together with any SDK changes that are necessary. The storage and roughtime examples can be disabled as part of that, we'll figure out what to do about them in a separate PR (either delete them, or re-enable them when the corresponding functionality is available in the Rust loader).

@ipetr0v
Copy link
Contributor Author

ipetr0v commented May 7, 2020

I thought to add this commit in order to make later changes (such as gRPC client and streaming support) be easier to implement - since they all will be tested in the CI and they will not become a single giant PR.

Run running_average

Update scripts

Update examples

Run examples with the Rust Oak Loader

Delete default from rustfmt

Decode GrpcResponse
@ipetr0v ipetr0v changed the title Run both C++ and Rust Loader Use Rust Loader for running examples May 13, 2020
@ipetr0v ipetr0v changed the title Use Rust Loader for running examples Run both C++ and Rust Loader May 14, 2020
@ipetr0v ipetr0v closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide gRPC read handle to the Oak entrypoint
3 participants