Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops changes for Program join stories (ED-599) && Block Level Filters (ED-94) #3737

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Devops changes for Program join stories (ED-599) && Block Level Filters (ED-94) #3737

merged 4 commits into from
Apr 27, 2023

Conversation

VISHNUDAS-tunerlabs
Copy link
Contributor

@VISHNUDAS-tunerlabs VISHNUDAS-tunerlabs commented Feb 17, 2023

Design Document Program Join

JIRA_STORY : ED-599

Design Document Block Level filters

JIRA_STORY : ED-94

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Enhancement (additive changes to improve performance)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Test A
  • Ran Test B

Test Configuration:

  • Software versions:
  • Hardware versions:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gandham-santhosh
Copy link
Collaborator

@VISHNUDAS-tunerlabs can you please share the design document for the new API you are onboarding? For any new API we onboard, we want it to go through design review and then publish the same

Copy link
Contributor

@aks30 aks30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should raise it to 5.2.0. Also please share confluence doc and JIRA story corresponding to this in the new PR

Copy link
Contributor

@aks30 aks30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on 7 April

ansible/roles/stack-sunbird/templates/ml-core-service.env Outdated Show resolved Hide resolved
ansible/roles/kong-api/defaults/main.yml Outdated Show resolved Hide resolved
@VISHNUDAS-tunerlabs VISHNUDAS-tunerlabs changed the base branch from release-5.1.0 to release-6.0.0 April 26, 2023 06:55
@VISHNUDAS-tunerlabs VISHNUDAS-tunerlabs changed the title Devops changes for PII data stories Devops changes for Program join stories (ED-599) && Block Level Filters (ED-94) Apr 26, 2023
Copy link
Contributor

@aks30 aks30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@gandham-santhosh gandham-santhosh merged commit 634bb0a into project-sunbird:release-6.0.0 Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants