Low Fidelity Prototype for Home Page #548
Conversation
Starting point for project-travel-mate#534 Added the 'Offline Maps' section to the Navigation Drawer complete with the icon. 'fragment_offlinemaps.xml' and 'OfflineMapsFragment.java' also created.
Implemented the changes as requested by the discussion in project-travel-mate#545.
The created .xml file is temporary only and is meant for prototyping. Later PRs that are related to this issue should have at least a workable definition for it.
|
Please add a screenshot also. |
| @@ -0,0 +1,2 @@ | |||
| # Auto detect text files and perform LF normalization | |||
There was a problem hiding this comment.
I just included the .gitattributes file to fix the line endings formatting but forgot to add the file to the .gitignore.
| @@ -0,0 +1,24 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
remove .idea folder from commit
| @@ -0,0 +1,2 @@ | |||
| .idea | |||
There was a problem hiding this comment.
we already have a gitignore file. Add these there only
| @@ -233,7 +233,9 @@ private Fragment getFragmentByNavMenuItemId(int id) { | |||
| case R.id.nav_utility: | |||
| fragment = UtilitiesFragment.newInstance(); | |||
| break; | |||
|
|
|||
| //Work In Progress Offline Maps | |||
There was a problem hiding this comment.
this change shouldnt be a part of this commit
There was a problem hiding this comment.
Yeah, I was meaning to ignore this file change but it still got mixed in the commit.
| @@ -1,7 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <menu xmlns:android="http://schemas.android.com/apk/res/android"> | |||
|
|
|||
| <group android:checkableBehavior="single" android:id="@+id/nav_grp1"> | |||
| <group | |||
There was a problem hiding this comment.
these changes shouldnt be a part of your commit
There was a problem hiding this comment.
I don't know why this file was changed in the commit when I didn't touch it.
There was a problem hiding this comment.
may be, because you created this branch from the branch that has the changes the related to offline maps. So, those were also included here.
|
Can you add cardview to it? and make it a bit more colorful. This UI cant be reused. |
|
cant be used. |
Description
Prototype for the home page is made. It is still a low fidelity prototype and definitely needs changes as it doesn't use the CardView component at all and instead relied on ImageView and TextView components to design a layout. This prototype is related to the issue discussed at #511 .
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist:
Screenshots