-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling incomplete logs and reject broken files #47
Conversation
…rable pwal entries
…ds in limestone::internal namespace, and add unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一か所だけ要検討で、他は問題なさそうです。
大したコメントはできませんが、一点。 limestone/src/limestone/log_entry.h Line 199 in 4d6a524
は、default:にfall throuthさせるなら不要かと(あっても動作に関する問題はありませんが)。 |
(suggested by PR comment)
and remove trailing whitespaces in line.
コメントありがとうございます。その case を消しました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
マージします |
WAL ファイルの取り扱いを頑強にする修正です
案件: https://github.com/project-tsurugi/tsurugi-issues/issues/461 (症状4)