Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

introduce podman sanity checks #417

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

miabbott
Copy link
Collaborator

@miabbott miabbott commented Jun 20, 2018

podman is included in most (all?) of the AH streams that we are testing, so let's start making sure it works on Atomic Host.

This is a re-implementation of the docker_pull_run_remove role that uses podman. It's slightly more comprehensive than the original role, but still very bare bones.

Closes #378

@miabbott
Copy link
Collaborator Author

There is an existing BZ or two about network access when using podman run that is going to bite us with this test.

I could add a separate tag that we could filter on or just wait until the BZs are fixed to merge this.

@mike-nguyen
Copy link
Collaborator

I'm okay with waiting for the BZs. Can you copy the BZs here so when they're fixed, I can just re-run and merge this?

@miabbott
Copy link
Collaborator Author

@mike-nguyen my understanding is that we need this containernetworking/plugins#75 merged and then we need a new build of podman

@mike-nguyen
Copy link
Collaborator

Is this temporarily fixed with this: containers/podman#1431 ?

@miabbott
Copy link
Collaborator Author

It should be; but we still have to wait for builds to land across all the platforms.

@miabbott
Copy link
Collaborator Author

bot, retest this please

This introduces a new role named `podman_pull_run_remove` which is a
implementation of `docker_pull_run_remove` using `podman`.

The role has been enhanced to test basic running of containers and
also testing network access from the container.  (These enhancements
should likely be applied to `docker_pull_run_remove`, too).
Let's start testing `podman` on the hosts that support it.
@miabbott
Copy link
Collaborator Author

bot, retest this please

@miabbott
Copy link
Collaborator Author

CentOS is still going to fail because the build of podman is too old to have the fix for --net=host, but everything else should be OK.

@mike-nguyen
Copy link
Collaborator

@miabbott I'm not too concerned about CentOS7. CAHC seems to be failing pulling from registry.access.redhat.com because it doesn't have a cert. If one is required can we put one in or just skip the r.a.rh.com test completely?

@miabbott
Copy link
Collaborator Author

Yeah, the root cause is here:

CentOS/sig-atomic-buildscripts#329

I think there is still value in pulling from registry.access.redhat.com, so I'll further adjust the test to skip that registry on CAHC

CentOS AH is missing the Red Hat CA cert, so it is unable to pull
images from the registry (see:  CentOS/sig-atomic-buildscripts#329).
To workaround this, we'll have to build the list of images to pull
differently for CentOS vs. the rest.
@miabbott
Copy link
Collaborator Author

Just pushed a new commit with fixes. ⬆️

The CI checks are probably going to fail because OpenStack is bad and should feel bad.

@mike-nguyen
Copy link
Collaborator

Look, it worked!

@mike-nguyen
Copy link
Collaborator

LGTM!

@mike-nguyen mike-nguyen merged commit 494eb7c into projectatomic:master Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants