Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bootstrap 4 support #3226

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Remove bootstrap 4 support #3226

merged 1 commit into from
Sep 23, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Jul 18, 2024 •
edited
Loading

Fixes #3211

@jcoyne jcoyne added this to the 9.X milestone Jul 18, 2024
@jcoyne jcoyne mentioned this pull request Aug 7, 2024
Merged
@jcoyne jcoyne force-pushed the remove-bootstrap4 branch from 5ce06e0 to ac4bb61 Compare August 7, 2024 16:27
thatbudakguy
thatbudakguy approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@thatbudakguy thatbudakguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good and seems to be limited to:

  • remove sr-only and sr-only-focusable references
  • a few bs4 specific things in the asset generator

Unrelatedly, all of the locale files got formatted to change the quote type. Should that be in this PR?

@thatbudakguy thatbudakguy mentioned this pull request Sep 19, 2024
Merged
@jcoyne
Copy link
Member Author

jcoyne commented Sep 19, 2024

@thatbudakguy #3322 to tidy up the quotes elsewhere.

@jcoyne jcoyne merged commit 1bfd263 into main Sep 23, 2024
11 checks passed
@jcoyne jcoyne deleted the remove-bootstrap4 branch September 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatbudakguy thatbudakguy thatbudakguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.X
Development

Successfully merging this pull request may close these issues.

Bootstrap 4 is EOL. Stop supporting it?
2 participants
@jcoyne @thatbudakguy