fix show label in metadatadocument #3304

dnoneill · 2024-08-29T19:46:24Z

closes #3303

jcoyne

Are you able to add a test to this PR that shows the fix?

dnoneill · 2024-08-30T17:48:43Z

Yes. Do you want me to include screenshots. I tested it locally to make sure it was working.

jcoyne · 2024-08-30T19:12:57Z

@dnoneill I'd like an automated test please. That way we don't have any accidental regressions.

dnoneill · 2024-08-30T19:50:10Z

Gotcha. Can do.

spec/components/blacklight/document_component_spec.rb

marlo-longley approved these changes Aug 30, 2024

View reviewed changes

jcoyne requested changes Aug 30, 2024

View reviewed changes

dnoneill force-pushed the 3303-bug branch 2 times, most recently from c30499a to 7552357 Compare August 30, 2024 20:03

dnoneill requested a review from jcoyne August 30, 2024 20:04

dnoneill force-pushed the 3303-bug branch from 7552357 to f398e0c Compare August 30, 2024 21:33

jcoyne requested changes Sep 3, 2024

View reviewed changes

spec/components/blacklight/document_component_spec.rb Show resolved Hide resolved

dnoneill force-pushed the 3303-bug branch 2 times, most recently from a3e280c to 14f1c4f Compare September 4, 2024 16:43

dnoneill requested a review from jcoyne September 4, 2024 16:50

jcoyne reviewed Sep 4, 2024

View reviewed changes

spec/components/blacklight/document_component_spec.rb Outdated Show resolved Hide resolved

fix show label in metadatadocument

5f422fa

dnoneill force-pushed the 3303-bug branch from 14f1c4f to 5f422fa Compare September 4, 2024 20:38

jcoyne approved these changes Sep 4, 2024

View reviewed changes

jcoyne merged commit 9fc6669 into projectblacklight:main Sep 4, 2024
13 checks passed

cbeer pushed a commit that referenced this pull request Sep 21, 2024

Fix show label in document metadata (backport #3304)

83b781a

Provide feedback