Add a way to filter facets in the facets "more" modal #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new endpoint at /catalog/facet/<facet_name>/<query_fragment> Co-authored-by: Isha Sinha <[email protected]>
sandbergja
force-pushed
the
facet-typeahead
branch
from
0c84bc6 to
e026124
Compare
Co-authored-by: Christina Chortaria <[email protected]>
sandbergja
force-pushed
the
facet-typeahead
branch
from
e026124 to
36c04e5
Compare
Closed
5 tasks
|
Wow, this is a feature people have wanted for a while -- I was never able to figure out a way to do it, perhaps I was looking before facet.contains existed! This is incredible work -- sure took touching a lot of files! |
jrochkind
reviewed
Oct 16, 2024
Rather than two very similar controller actions for facets vs. facet_suggest, this commit combines them into a single controller action.
sandbergja
added a commit
that referenced
this pull request
Oct 17, 2024
* Facet typeahead: back end This creates a new endpoint at /catalog/facet/<facet_name>/<query_fragment> Co-authored-by: Isha Sinha <[email protected]> * Facet typeahead: front end Co-authored-by: Christina Chortaria <[email protected]> * bundle exec i18n-tasks add-missing * Incorporate feedback from review Rather than two very similar controller actions for facets vs. facet_suggest, this commit combines them into a single controller action. --------- Co-authored-by: Isha Sinha <[email protected]> Co-authored-by: Christina Chortaria <[email protected]>
sandbergja
added a commit
that referenced
this pull request
Oct 21, 2024
* Facet typeahead: back end This creates a new endpoint at /catalog/facet/<facet_name>/<query_fragment> Co-authored-by: Isha Sinha <[email protected]> * Facet typeahead: front end Co-authored-by: Christina Chortaria <[email protected]> * bundle exec i18n-tasks add-missing * Incorporate feedback from review Rather than two very similar controller actions for facets vs. facet_suggest, this commit combines them into a single controller action. --------- Co-authored-by: Isha Sinha <[email protected]> Co-authored-by: Christina Chortaria <[email protected]>
sandbergja
added a commit
that referenced
this pull request
Oct 22, 2024
* Facet typeahead: back end This creates a new endpoint at /catalog/facet/<facet_name>/<query_fragment> Co-authored-by: Isha Sinha <[email protected]> * Facet typeahead: front end Co-authored-by: Christina Chortaria <[email protected]> * bundle exec i18n-tasks add-missing * Incorporate feedback from review Rather than two very similar controller actions for facets vs. facet_suggest, this commit combines them into a single controller action. --------- Co-authored-by: Isha Sinha <[email protected]> Co-authored-by: Christina Chortaria <[email protected]>
maxkadel
added a commit
that referenced
this pull request
Dec 17, 2024
…t-to-8 Backport #3367 to 8.x (Add a way to filter facets in the facets "more" modal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2123
This adds an input that allows the user to type a fragment of the facet value that interests them. The facet values are filtered to match only this filter using Solr's
facet.contains(thanks @magibney for pointing that out), as illustrated in the gif below.Thank you to @christinach and @ishasinha1 for your collaboration. Thanks in advance for your feedback!