Restore modal events that were dropped in Blacklight 8 #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand why the bootstrap-triggered events were removed with the switch to HTML5-native modals, but I'm not sure why the
loaded.blacklight.blacklight-modal. This was a very useful extension point for plugins and other applications, and requiring all of them to set up mutation observers (e.g projectblacklight/blacklight_range_limit#249) isn't very satisfying.I also added show + hide events (the
<dialog>emits its owncloseevent) to restore some other useful extension points too.