Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on rails 8.0.0.rc2 #3424

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Test on rails 8.0.0.rc2 #3424

merged 2 commits into from
Nov 1, 2024

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Oct 31, 2024

No description provided.

@jrochkind
Copy link
Member

jrochkind commented Oct 31, 2024

I don't know wha'ts up with test failure, which is not in the new rails version. Flakey race condition spec?


  1. Search Results context passes the current search id through
    Failure/Error: expect(page).to have_content "U21.2 .W85 2003"
    expected to find text "U21.2 .W85 2003" in "Blacklight\nBookmarks 0\nHistory\nLogin\nSearch in\nAll Fields\nTitle\nAuthor\nSubject\nsearch for\nSearch\nStart Over\nBack to Search\n« Previous | 10 of 30 | Next »\nPluvial nectar of blessings :\nTitle:\nPluvial nectar of blessings :\nSubtitle:\na supplication to the noble Lama Mahaguru Padmasambhava /\nAuthor:\nṄag-dbaṅ-blo-bzaṅ-rgya-mtsho, Dalai Lama V, 1617-1682\nFormat:\nBook\nLanguage:\nEnglish and Tibetan\nPublished:\nDharamsala\nCall number:\nBQ5593.P3 N3313 2002\nISBN:\n8186470336\nTools\nBookmark\nEmail\nSMS This\nCite"

    ./spec/features/search_context_spec.rb:13:in `block (2 levels) in <top (required)>'

@jcoyne
Copy link
Member Author

jcoyne commented Oct 31, 2024

Yes, that's a flappy spec.

Copy link
Contributor

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jcoyne !

@sandbergja sandbergja merged commit 74008cf into main Nov 1, 2024
13 checks passed
@sandbergja sandbergja deleted the test-rc2 branch November 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants