Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for 9.0.0 final release #307

Merged
merged 1 commit into from
Jan 7, 2025
Merged

prepare for 9.0.0 final release #307

merged 1 commit into from
Jan 7, 2025

Conversation

jrochkind
Copy link
Member

No description provided.

@jrochkind
Copy link
Member Author

Doh! Version bump only is failing in only one CI cell.

Failing on bl ~> 8.0 / rails 7.2.1 / rb 3.3 / importmap-rails, propshaft, which is a pretty crucial one! Have re-run failed build twice, kept failing.

I am not sure what changed since last successful CI, this is annoying! Or why it would only effect that build

Will try to fix out of this PR, may start with another empty commit PR.

Failures:
  1) Run through with javascript basically works
     Failure/Error: expect(page).to have_css('canvas')
       expected to find css "canvas" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/MAIN[1]/DIV[2]/SECTION[2]/SEARCH[1]/DIV[1]/DIV[2]/DIV[1]"> but there were no matches
       Browser console:
       SEVERE: http://127.0.0.1:37695/assets/application-9dd3ef3f.js 6:0 Uncaught SyntaxError: Identifier 'githubAutoCompleteElement' has already been declared
     # ./spec/features/run_through_spec.rb:34:in `block (3 levels) in <top (required)>'
     # ./spec/features/run_through_spec.rb:33:in `block (2 levels) in <top (required)>'
  2) Run through with javascript for single dates does not show chart or facet list
     Failure/Error: last_date = find("input#range_pub_date_si_begin").value
     Capybara::ElementNotFound:
       Unable to find visible css "input#range_pub_date_si_begin" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/MAIN[1]/DIV[2]/SECTION[2]/SEARCH[1]/DIV[1]/DIV[2]/DIV[1]">
       Browser console:
       SEVERE: http://127.0.0.1:37695/assets/application-9dd3ef3f.js 6:0 Uncaught SyntaxError: Identifier 'githubAutoCompleteElement' has already been declared
     # ./spec/features/run_through_spec.rb:79:in `block (4 levels) in <top (required)>'
     # ./spec/features/run_through_spec.rb:78:in `block (3 levels) in <top (required)>'
  3) Run through with javascript open-ended range can search
     Failure/Error: find("input#range_pub_date_si_begin").set("")
     Capybara::ElementNotFound:
       Unable to find visible css "input#range_pub_date_si_begin" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/MAIN[1]/DIV[2]/SECTION[2]/SEARCH[1]/DIV[1]/DIV[2]/DIV[1]">
       Browser console:
       SEVERE: http://127.0.0.1:37695/assets/application-9dd3ef3f.js 6:0 Uncaught SyntaxError: Identifier 'githubAutoCompleteElement' has already been declared
     # ./spec/features/run_through_spec.rb:101:in `block (4 levels) in <top (required)>'
     # ./spec/features/run_through_spec.rb:100:in `block (3 levels) in <top (required)>'
  4) Run through with javascript submitted with empty boundaries does not apply filter
     Failure/Error: find("input#range_pub_date_si_begin").set("")
     Capybara::ElementNotFound:
       Unable to find visible css "input#range_pub_date_si_begin" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/MAIN[1]/DIV[2]/SECTION[2]/SEARCH[1]/DIV[1]/DIV[2]/DIV[1]">
       Browser console:
       SEVERE: http://127.0.0.1:37695/assets/application-9dd3ef3f.js 6:0 Uncaught SyntaxError: Identifier 'githubAutoCompleteElement' has already been declared
     # ./spec/features/run_through_spec.rb:125:in `block (4 levels) in <top (required)>'
     # ./spec/features/run_through_spec.rb:124:in `block (3 levels) in <top (required)>'
  5) Run through with javascript when assumed boundaries configured should show the range limit with set boundaries
     Failure/Error: expect(find("input#range_pub_date_si_begin").value).to be_present
     Capybara::ElementNotFound:
       Unable to find visible css "input#range_pub_date_si_begin"
       Browser console:
       SEVERE: http://127.0.0.1:37695/assets/application-9dd3ef3f.js 6:0 Uncaught SyntaxError: Identifier 'githubAutoCompleteElement' has already been declared
     # ./spec/features/run_through_spec.rb:154:in `block (3 levels) in <top (required)>'
     # ./spec/features/run_through_spec.rb:145:in `block (3 levels) in <top (required)>'
  6) Run through with javascript Range Limit text facets work with strict permitted params
     Failure/Error: find("summary", text: "Range List").click
     Capybara::ElementNotFound:
       Unable to find css "summary" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/MAIN[1]/DIV[2]/SECTION[2]/SEARCH[1]/DIV[1]/DIV[2]/DIV[1]">
       Browser console:
       SEVERE: http://127.0.0.1:37695/assets/application-9dd3ef3f.js 6:0 Uncaught SyntaxError: Identifier 'githubAutoCompleteElement' has already been declared
       SEVERE: http://127.0.0.1:37695/assets/application-9dd3ef3f.js 6:0 Uncaught SyntaxError: Identifier 'githubAutoCompleteElement' has already been declared
     # ./spec/features/run_through_spec.rb:198:in `block (4 levels) in <top (required)>'
     # ./spec/features/run_through_spec.rb:197:in `block (3 levels) in <top (required)>'
     # ./spec/features/run_through_spec.rb:186:in `block (3 levels) in <top (required)>'

@jrochkind
Copy link
Member Author

fixed problem, rebased, self-merging version bump only, releasing.

@jrochkind jrochkind merged commit 83d3ce7 into main Jan 7, 2025
9 checks passed
@jrochkind jrochkind deleted the prepare-9.0.0 branch January 7, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant