Preventing exhibit navb deprecation messages when not needed #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
approved these changes
Oct 17, 2024
|
Do we also want to avoid calling the exhibit_navbar partial if the component is defined? |
|
@jcoyne not sure about that just yet, given how the partial is called from the masthead file: https://github.com/projectblacklight/spotlight/blob/main/app/views/shared/_masthead.html.erb#L11 . I think we would have to rewrite this part as components as well first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3200 .
What this PR does:
Updates the code to only throw a deprecation warning if the exhibit navbar component is not set in the configuration.