Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bootstrap for reveal/collapse contact form #3379

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Dec 19, 2024

This provides better accessibility (aria-expanded) than our custom solution

Copy link
Contributor

@corylown corylown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but needs rebase before merge.

@jcoyne jcoyne force-pushed the bootstrap-collapse branch 3 times, most recently from 98a2f93 to f515b58 Compare December 20, 2024 21:44
@dnoneill
Copy link
Contributor

dnoneill commented Jan 6, 2025

@jcoyne please rebase.

This provides better accessibility (aria-expanded) than our custom solution
@jcoyne jcoyne force-pushed the bootstrap-collapse branch from f515b58 to ebda9f7 Compare January 6, 2025 21:05
@dnoneill dnoneill merged commit b324cd0 into main Jan 9, 2025
5 checks passed
@dnoneill dnoneill deleted the bootstrap-collapse branch January 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants