Handle backend watch, if upstream closes channel[ClosedByRemote] #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishgobinath
force-pushed
the
update-syncer
branch
from
b33ec26 to
5f4021d
Compare
krishgobinath
changed the title
|
@krishgobinath @robbrockbank the changes to etcdv3/watcher.go in this PR seems to have broken calico using etcd backend, under certain error scenarios. : projectcalico/calico#4109 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles following things.
If upstream Kubernetes API server closes watch the channel with backend libcalico-go, then stop the backend channels connected downstream and don't send any "ErrorTerminated" events back to downstream channels.
If upstream Kubernetes API server, sends Api.WatchError to backend libcalico-go, wrap this status change as an "ApiError" to downstream. Downstream will resync the channel.
Local Unit test passed.