Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd backend not passing watcher errors up the stack, and errors not … #1338

Merged
merged 1 commit into from
Oct 30, 2020
Merged

etcd backend not passing watcher errors up the stack, and errors not … #1338

merged 1 commit into from
Oct 30, 2020

Conversation

robbrockbank
Copy link
Contributor

@robbrockbank robbrockbank commented Oct 30, 2020 •
edited
Loading

…triggering full resync in watcher cache

Description

This is a cherry-pick from master of #1337

Todos

  • Tests
  • Documentation
  • Release note

Release Note

When using etcdv3 backend, some watchers may fail to resynchronize data after an etcd compaction. This is fixed across various components.

@marvin-tigera marvin-tigera added this to the Calico v3.16.5 milestone Oct 30, 2020
mgleung
mgleung approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@mgleung mgleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgleung mgleung merged commit 6b3cd56 into projectcalico:release-v3.16 Oct 30, 2020
@robbrockbank robbrockbank deleted the fix-watch-errors branch October 30, 2020 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgleung mgleung mgleung approved these changes

Assignees
No one assigned
Labels
docs-pr-required release-note-required
Projects
None yet
Milestone
Calico v3.16.5
Development

Successfully merging this pull request may close these issues.
3 participants
@robbrockbank @mgleung @marvin-tigera