feat: show better error message for failing validations #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanH90
force-pushed
the
fix/show-better-error-msg
branch
from
42fde47 to
c6addde
Compare
anehx
approved these changes
Nov 28, 2023
|
🎉 This PR is included in version 12.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we always show a technical error message when an answer could not be saved, even if it is due to an incorrect validation (which is not a technical error). In this MR, this gets slightly reworked to show some more detailed information:
for validation errors
when being offline
fallback, actual technical error
(i just doctored the text in which is why there is no actual technical infos shown but the MR doesnt touch that bit)