Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: support backend appProtocol #5934

Merged
merged 15 commits into from
Nov 15, 2023
Merged

Gateway API: support backend appProtocol #5934

merged 15 commits into from
Nov 15, 2023

Conversation

izturn
Copy link
Member

@izturn izturn commented Nov 3, 2023

Signed-off-by: Gang Liu [email protected]

fix #5897

@izturn izturn requested a review from a team as a code owner November 3, 2023 07:07
@izturn izturn requested review from tsaarni and stevesloka and removed request for a team November 3, 2023 07:07
@izturn izturn self-assigned this Nov 3, 2023
@izturn izturn requested review from skriss and sunjayBhatia and removed request for stevesloka November 3, 2023 07:07
@izturn izturn added area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note/small A small change that needs one line of explanation in the release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 3, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

Merging #5934 (632e89b) into main (6ff341d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5934      +/-   ##
==========================================
+ Coverage   78.56%   78.59%   +0.02%     
==========================================
  Files         139      139              
  Lines       19615    19638      +23     
==========================================
+ Hits        15411    15434      +23     
  Misses       3901     3901              
  Partials      303      303
Files Coverage Δ
internal/dag/accessors.go 87.34% <100.00%> (+0.67%) ⬆️
internal/dag/gatewayapi_processor.go 93.84% <100.00%> (+0.04%) ⬆️

@izturn
add change log
30babff 
Signed-off-by: gang.liu <[email protected]>
@izturn izturn marked this pull request as draft November 3, 2023 08:07
@izturn
skip HTTPRoute ws check
53ed202 
Signed-off-by: gang.liu <[email protected]>
@izturn izturn marked this pull request as ready for review November 3, 2023 09:48
@sunjayBhatia sunjayBhatia added release-note/minor A minor change that needs about a paragraph of explanation in the release notes. and removed release-note/small A small change that needs one line of explanation in the release notes. labels Nov 3, 2023
@sunjayBhatia
Copy link
Member

upgraded the release note to minor

@izturn izturn requested a review from sunjayBhatia November 6, 2023 08:29
@izturn
Copy link
Member Author

izturn commented Nov 6, 2023

btw the check: gateway-conformance is good and bad at times

skriss
skriss requested changes Nov 7, 2023
View reviewed changes
changelogs/unreleased/5934-izturn-minor.md Outdated Show resolved Hide resolved
internal/dag/gatewayapi_processor.go Outdated Show resolved Hide resolved
internal/dag/gatewayapi_processor.go Outdated Show resolved Hide resolved
internal/dag/accessors.go Outdated Show resolved Hide resolved
@skriss
Copy link
Member

skriss commented Nov 7, 2023

btw the check: gateway-conformance is good and bad at times

If you see tests related to this change flaking, that'd be good to know, otherwise yeah we have seen some other flakes from time to time, we're trying to track them down and resolve them though.

@izturn izturn requested a review from skriss November 8, 2023 07:25
skriss
skriss requested changes Nov 8, 2023
View reviewed changes
internal/dag/accessors.go Outdated Show resolved Hide resolved
internal/dag/accessors.go Outdated Show resolved Hide resolved
internal/dag/accessors.go Show resolved Hide resolved
@izturn
little refactor
2cfdfee 
Signed-off-by: gang.liu <[email protected]>
@izturn izturn requested a review from skriss November 9, 2023 01:49
skriss
skriss requested changes Nov 9, 2023
View reviewed changes
changelogs/unreleased/5934-izturn-minor.md Outdated Show resolved Hide resolved
changelogs/unreleased/5934-izturn-minor.md Outdated Show resolved Hide resolved
@izturn
adjust changelog
632e89b 
Signed-off-by: gang.liu <[email protected]>
@izturn izturn requested a review from skriss November 10, 2023 06:28
@izturn
Copy link
Member Author

izturn commented Nov 14, 2023

ping @skriss @sunjayBhatia

skriss
skriss approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skriss skriss changed the title GatewayAPI: Support backend appProtocol Gateway API: support backend appProtocol Nov 14, 2023
@sunjayBhatia sunjayBhatia merged commit 9b4f666 into projectcontour:main Nov 15, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia approved these changes

@skriss skriss skriss approved these changes

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

Assignees

@izturn izturn

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway API: support backend appProtocol
3 participants
@izturn @sunjayBhatia @skriss