Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove contour xDS server implementation #6568

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skriss
Copy link
Member

@skriss skriss commented Jul 19, 2024

Closes #2134.

@skriss skriss added this to the 1.31.0 milestone Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.70%. Comparing base (3cac9fc) to head (cef7058).

Files with missing lines Patch % Lines
cmd/contour/serve.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6568      +/-   ##
==========================================
- Coverage   81.05%   80.70%   -0.36%     
==========================================
  Files         133      130       -3     
  Lines       20026    19738     -288     
==========================================
- Hits        16232    15929     -303     
- Misses       3500     3519      +19     
+ Partials      294      290       -4     
Files with missing lines Coverage Δ
cmd/contour/servecontext.go 84.34% <ø> (-0.18%) ⬇️
internal/contourconfig/contourconfiguration.go 98.17% <ø> (-0.02%) ⬇️
internal/xds/v3/callbacks.go 100.00% <100.00%> (ø)
internal/xdscache/v3/cluster.go 100.00% <ø> (ø)
internal/xdscache/v3/endpointslicetranslator.go 74.51% <ø> (-7.27%) ⬇️
internal/xdscache/v3/endpointstranslator.go 87.45% <ø> (-1.68%) ⬇️
internal/xdscache/v3/listener.go 91.54% <ø> (-0.45%) ⬇️
internal/xdscache/v3/route.go 96.90% <ø> (-0.56%) ⬇️
internal/xdscache/v3/runtime.go 97.43% <ø> (-2.57%) ⬇️
internal/xdscache/v3/secret.go 66.66% <ø> (-10.70%) ⬇️
... and 2 more

... and 2 files with indirect coverage changes

@skriss skriss force-pushed the pr-rm-contour-xds branch 2 times, most recently from 0a90610 to 70b2eff Compare August 1, 2024 14:36
@skriss skriss force-pushed the pr-rm-contour-xds branch from 70b2eff to 88cf463 Compare January 8, 2025 17:22
skriss added 2 commits January 8, 2025 12:32
Signed-off-by: Steve Kriss <[email protected]>
@skriss skriss force-pushed the pr-rm-contour-xds branch from 88cf463 to cef7058 Compare January 8, 2025 17:37
@skriss skriss added the release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes. label Jan 8, 2025
@skriss skriss marked this pull request as ready for review January 8, 2025 17:39
@skriss skriss requested a review from a team as a code owner January 8, 2025 17:39
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team January 8, 2025 17:39
@skriss
Copy link
Member Author

skriss commented Jan 8, 2025

Calling this one ready for review, are others comfortable moving forward with this cleanup?

@sunjayBhatia sunjayBhatia requested review from a team, rajatvig and clayton-gonsalves and removed request for a team January 8, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/deprecation A deprecation or removal that needs about a paragraph of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace GRPC server with envoy's go-control-plane
1 participant