add no-clobber flag #827
Merged
add no-clobber flag #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
reviewed
Mar 29, 2024
dogancanbakir
force-pushed
the
introduce_incremental_crawling
branch
from
f95ee1e to
26f87d8
Compare
Mzack9999
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
lgtm - The current implementation acts by increasing the folder name version number if an existing one is detected.
$ go run . -ncb -srd test -u http://scanme.sh
$ ls
Directory: C:\Users\user\go\src\github.com\projectdiscovery\katana\cmd\katana
Mode LastWriteTime Length Name
---- ------------- ------ ----
d----- 29/04/2024 14:42 test
d----- 29/04/2024 14:42 test1
d----- 29/04/2024 14:46 test10
d----- 29/04/2024 14:46 test11
d----- 29/04/2024 14:43 test2
d----- 29/04/2024 14:43 test3
d----- 29/04/2024 14:44 test4
d----- 29/04/2024 14:44 test5
d----- 29/04/2024 14:45 test6
d----- 29/04/2024 14:45 test7
d----- 29/04/2024 14:45 test8
d----- 29/04/2024 14:46 test9
Mzack9999
added
the
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749
This PR modifies the behavior of the
store-response-dirdirectory creation. With the new-no-clobberflag, the directory will be created as is if there are no existing directories. However, if directories already exist, it will increase the number suffix of the given directory or add a new suffix. When removing directories, all created directories will be removed.